search

cksource-archive / samples-framework

☠☠☠ This repository is no longer used ☠☠☠
Other
0 stars 0 forks source link

Footer has incorrect structure #45

Open Reinmar opened 9 years ago

Reinmar commented 9 years ago

In samples/cke-basic there's:

    <footer class="footer-a grid-container">
        <div class="grid-container">
            <p class="grid-width-100">
                CKEditor &ndash; The text editor for the Internet &ndash; <a href="http://ckeditor.com/">http://ckeditor.com</a>
            </p>
            <p class="grid-width-100">
                Copyright &copy; 2003-2015, <a class="samples" href="http://cksource.com/">CKSource</a> &ndash; Frederico
                Knabben. <a href="license.html">All rights reserved</a>.
            </p>
        </div>
    </footer>

Duplication of the grid-container class seems to be incorrect.

Please also check footers in ckeditor-dev (sample and configurator).

vokiel commented 9 years ago

BTW. Do we need the grid-width-100 for paragraphs? IMHO they should fill their containers by default (after removing https://github.com/cksource/samples-framework/blob/master/components/footer-a/footer-a.less#L13).