Bootstrap command will retry itself if failed

cksource / mrgit

A tool for managing projects build using multiple repositories.

49 stars 9 forks source link

Bootstrap command will retry itself if failed #91

Closed pomek closed 5 years ago

pomek commented 5 years ago

Suggested merge commit message (convention)

Feature: Introduced a mechanism which allows executing bootstrap command once again if it ends with an error. Closes #87.

pomek commented 5 years ago

We tested it with @scofalik and seems to work.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 254

18 of 18 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.08%) to 98.977%

Totals
Change from base Build 237:	0.08%
Covered Lines:	302
Relevant Lines:	304

💛 - Coveralls

ma2ciek commented 5 years ago

It happened to me once during the mgit update command. I'm not sure if we should patch also this command. (For now, the only one used in reset script is bootstrap, so for now it should be ok)

pomek commented 5 years ago

mgit update calls bootstrap if the package isn't available.

ma2ciek commented 5 years ago

I'm not sure if we should mention in docs about this feature, but the functionality is not exposed so we can live with it.