cksource / mrgit

A tool for managing projects build using multiple repositories.
49 stars 9 forks source link

Introduced the "overrideDirectoryNames" option in a config #98

Closed pomek closed 5 years ago

pomek commented 5 years ago

Suggested merge commit message (convention)

Feature: Introduced an option (overrideDirectoryNames) that allows modifying a directory where a package would be cloned. Closes #72.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 289


Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/utils/getoptions.js 1 2 50.0%
<!-- Total: 5 6 83.33% -->
Totals Coverage Status
Change from base Build 284: -0.3%
Covered Lines: 490
Relevant Lines: 491

💛 - Coveralls
pomek commented 5 years ago

Ping, @Reinmar or @ma2ciek.

pomek commented 5 years ago

Could you show how I can easily change existing mgit.json to test it?

Modify your mgit.json according to https://github.com/cksource/mgit2/issues/72. To be honest, the entire test case was described in the ticket.

ma2ciek commented 5 years ago

All works fine!

Despite testing, but it's a thing for the future (as right now the test env is inside the @ckeditor/ckeditor5-cloud-services-core package).