ckuburlis / homebridge-tado

16 stars 15 forks source link

Only turning off The A/C works. #5

Closed SRv6d closed 7 years ago

SRv6d commented 8 years ago

I can turn off the A/C using this plugin but thats it. Changing the temperature doesn't work, changing between heating/cooling doesn't work and turning on the A/C doesn't work either.

kaiatkins commented 8 years ago

I have the same issue

jhavenhill commented 8 years ago

Same issue here. Nothing works except turning off the A/C

jhavenhill commented 8 years ago

I fixed this for myself by modifying the request body that is sent in the setTargetTemperature function. My A/C does not have Fan Speed or Swing capabilities (the way it is set up with tado, at least), and manually calling /api/v2/homes/*****/zones/1/overlay returns:

{
    "type": "MANUAL",
    "setting": {
        "type": "AIR_CONDITIONING",
        "power": "ON",
        "mode": "COOL",
        "temperature": {
            "celsius": 22.78,
            "fahrenheit": 73
        }
    },
    "termination": {
        "type": "MANUAL",
        "projectedExpiry": null
    }
}

So, I simply removed the "swing" and "fanSpeed" entries, and now I am able to turn on my A/C and set the temperature. Perhaps it might be possible to add something like fanSpeed = False and swing = False to the config, for users whose A/Cs don't have these capabilities? Then these entries could be deleted from the request body as necessary.

jojoam commented 7 years ago

Same issue here, can only turn off the AC if it was previously turned on. Then after the AC is not responding to any control anymore. Fix from jhavenhill is not working for me.

dgaust commented 7 years ago

I also had this problem. I fixed it by editing the index.js file locally to remove "swing": "ON" from the json body (since my tado doesn't have swing support for my AC).

I also changed the termination type from MANUAL to TADO_MODE. This way it will still turn off when I leave the house, or a scheduled time kicks in.

That's a personal choice for me, it would be good to have a setting though.

jojoam commented 7 years ago

Hi,

I've removed "swing": "ON" and now it turns on and off correctly.

Thank you for the tip !

Joel

On 18 Nov 2016, at 10:36, dgaust notifications@github.com wrote:

I also had this problem. I fixed it by editing the index.js file locally to remove "swing": "ON" from the json body (since my tado doesn't have swing support for my AC).

I also changed the termination type from MANUAL to TADO_MODE. This way it will still turn off when I leave the house, or a scheduled time kicks in.

That's a personal choice for me, it would be good to have a setting though.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ckuburlis/homebridge-tado/issues/5#issuecomment-261477012, or mute the thread https://github.com/notifications/unsubscribe-auth/AVPUFlX79RZ9Ylt5_c7wcPEN8LbhSnibks5q_WOfgaJpZM4I0ado.

morilm commented 7 years ago

After suffering the same issue, I discovered that the index.js file that is installed by default is not the latest one, so the new settings (zones, swing...) doesn't work.

jojoam commented 7 years ago

So do you have the latest and solved the issue ?

בברכה,

יואל

On 19 Jan 2017, at 19:40, morilm notifications@github.com wrote:

After suffering the same issue, I discovered that the index.js file that is installed by default is not the latest one, so the new settings (zones, swing...) doesn't work.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

morilm commented 7 years ago

Yes. Last index.js support the zones.

  "accessory": "TADO",
  "name": "Salon",
  "homeID": "xxxxx",
  "maxValue": 27,
  "minValue": 18,
  "zone": 1,
  "username": "xxxx",
  "password": "xxxx",
  "useFanSpeed": "LOW",
  "useSwing": false,
  "useFahrenheit": false
jojoam commented 7 years ago

Hi,

Thank you again, but it still doesn't work for me.

Which Tado homebridge are you using ? homebridge tado or tadong ?

Could you send me your index.js ? (not the config.js)

Thanks

On 19 Jan 2017, at 20:44, morilm notifications@github.com wrote:

Yes. Last index.js support the zones.

"accessory": "TADO", "name": "Salon", "homeID": "xxxxx", "maxValue": 27, "minValue": 18, "zone": 1, "username": "xxxx", "password": "xxxx", "useFanSpeed": "LOW", "useSwing": false, "useFahrenheit": false — You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ckuburlis/homebridge-tado/issues/5#issuecomment-273861667, or mute the thread https://github.com/notifications/unsubscribe-auth/AVPUFoDn5cMQ8k4wfVKvLrpbUBAOT5pNks5rT68FgaJpZM4I0ado.

nitaybz commented 7 years ago

Hey Yoel! this git is for homebridge-tado not tado-ng, so having the last update of homebridge-tado should control your Tado AC smart Control smoothly, let me know if you have specific problems that I can help you with.

index.js can be found in this git codes.

jojoam commented 7 years ago

Hi,

Thank you for the update !

I've installed the latest version of homebridge-tado with the updated index.js and now I can control the Tado AC

Although I am able to turn on and change the temperature, I am not able to switch between modes: default is Cooling and the Tado is not responding to Auto and Heat.

Do you have any suggestion ?

Thank you

On 19 Jan 2017, at 22:16, nitaybz notifications@github.com wrote:

Hey Yoel! this git is for homebridge-tado not tado-ng, so having the last update of homebridge-tado should control your Tado AC smart Control smoothly, let me know if you have specific problems that I can help you with.

index.js can be found in this git codes.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ckuburlis/homebridge-tado/issues/5#issuecomment-273886387, or mute the thread https://github.com/notifications/unsubscribe-auth/AVPUFh4BqtQkI4xVKunqcqdCDvTeepniks5rT8SqgaJpZM4I0ado.

jojoam commented 7 years ago

Hello,

I have found that when installing homebridge-tado via "npm install -g homebridge" it do not install the latest index.js

When manually installing it, an error messageappears when running homebridge:

"Error: Cannot find module 'node-persist' at Function.Module._resolveFilename (module.js:325:15) at Function.Module._load (module.js:276:25) at Module.require (module.js:353:17) at require (internal/module.js:12:17) at new TadoAccessory (/usr/local/lib/node_modules/homebridge-tado/index.js:19:20) at Server._loadAccessories (/usr/local/lib/node_modules/homebridge/lib/server.js:265:29) at Server.run (/usr/local/lib/node_modules/homebridge/lib/server.js:81:38) at module.exports (/usr/local/lib/node_modules/homebridge/lib/cli.js:40:10) at Object. (/usr/local/lib/node_modules/homebridge/bin/homebridge:17:22) at Module._compile (module.js:409:26)"

Reinstalling and updating homebridge and node-persist did not solve the issue.

Joel

On 19 Jan 2017, at 22:16, nitaybz notifications@github.com wrote:

Hey Yoel! this git is for homebridge-tado not tado-ng, so having the last update of homebridge-tado should control your Tado AC smart Control smoothly, let me know if you have specific problems that I can help you with.

index.js can be found in this git codes.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ckuburlis/homebridge-tado/issues/5#issuecomment-273886387, or mute the thread https://github.com/notifications/unsubscribe-auth/AVPUFh4BqtQkI4xVKunqcqdCDvTeepniks5rT8SqgaJpZM4I0ado.

morilm commented 7 years ago

run npm install node-persist

at the command line to install it

nitaybz commented 7 years ago

that's weird... cause it does show in the dependencies, try removing this plugin and node-persist and install it again with sudo: sudo npm install -g https://github.com/ckuburlis/homebridge-tado.git

@ckuburlis Please push the new version to npm

jojoam commented 7 years ago

Hi,

Running this command did solve the issue, the plugin is now up to date along with the dependencies.

AC is now correctly responding to mode changes including heating.

Thank you for your patience and kind help.

By the way, I've spoke today with a Tado representative about the time frame of HomeKit integration for Tado AC and they told me that the first product to be HomeKit compliant will be the Tado Heating but not Tado AC

Tado AC won't be due in the near future.

Joel

On 20 Jan 2017, at 0:29, nitaybz notifications@github.com wrote:

that's weird... cause it does show in the dependencies, try removing this plugin and node-persist and install it again with sudo: sudo npm install -g https://github.com/ckuburlis/homebridge-tado.git

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ckuburlis/homebridge-tado/issues/5#issuecomment-273919361, or mute the thread https://github.com/notifications/unsubscribe-auth/AVPUFh1VB5HZedpbivZNPXlqeNZjmD0Nks5rT-PZgaJpZM4I0ado.

nitaybz commented 7 years ago

yup, I got the same answer from them as well, that's a bummer... Though I'm glad it worked for you now! I got 2 new Tado devices recently and I had to make it work properly!

Let me know if any improvements needed.