search

ckuhl / ImageBlockX

Block the loading of images in Firefox, saving your data
https://ckuhl.com/s/ImageBlockX
GNU General Public License v3.0
23 stars 6 forks source link

Icon / text will not change on toggle occasionally #6

Open jokervsbatman opened 6 years ago

jokervsbatman commented 6 years ago

There a notable bug I’ve come across when you’ve set the add-on to block all images, it occasionally doesn’t block all the images and essentially requires a refresh, but overall out of all the image block add-ons I’ve tested, it’s the best one for Firefox Quantum thus far. I’ll keep you posted on any other possible bugs I encounter.

ckuhl commented 6 years ago

Hmm, that's odd. Are there specific actions that cause this bug to happen? I am trying to replicate the bug but can't.

jokervsbatman commented 6 years ago

As far as I can tell, nah nothing out of the ordinary except so far it manifests on Facebook which materializes once in a blue moon. After an indirect trial and error, the effect isn't limited to Facebook.

ohhai commented 6 years ago

Side question: I see that this addon's button doesn't switch permissions.default.image preference. Is it OK?

ckuhl commented 6 years ago

@ohhai that shouldn't be an issue -- it gets stored settings (see code here) at launch and sets the image from there.

ckuhl commented 6 years ago

@jokervsbatman I'm still trying to replicate the behaviour but have been having a hard time. Are you still facing issues?

jokervsbatman commented 6 years ago

Yeah, the issue still exists. What perplexes me is the cause.

ohhai commented 6 years ago

I see something similar (maybe) on Firefox for Android. Once switched, can't switch back sometimes (at least the text in menu--I mean "images are allowed" or "images are blocked"). Can provide more detailed flow if necessary.

Off-topic request: is it possible to add the addon's button to browser's address field (only for Android)? I mean, some addons do that and it saves one extra click for every usage.

ckuhl commented 6 years ago

That sounds interesting -- I'll have to look into it when I get some spare time. The challenge for me will be getting a device that has Firefox Android on it, as I have an iPhone right now.

I haven't forgotten, I've just been really busy the past month!

ohhai commented 6 years ago

OK, I can try to debug it if you give me some highlights. How to monitor addon's state on a mobile device (variables, function calls, like usual debugger), remotely maybe, like that. There is something similar, but I never tried it.

ckuhl commented 6 years ago

Hi, I just realized that I never followed up on this after I made a few changes. Are you still having these issues?