ckypros / IOS-Tip-Calculator

Tip Calculator for iOS
0 stars 0 forks source link

Project Feedback! #1

Open codepathreview opened 2 years ago

codepathreview commented 2 years ago

Looks good, this exercise is intended in part to give you an introduction to the general rhythm of this course. The course is entirely project-based with an app being assigned each week and then due the following week. Each project builds on the last to help each engineer learn the practical elements of iOS development and best practices as quickly as possible. We also do a code review for each submitted project once the program begins.

The next step is to continue working on optional features and extending your tip calculator. With regards to extensions to implement, we are looking for developers with an interest in user experience and product development so be sure to focus on additional functional enhancements and/or improving the user interface of the app.

We have a detailed Prework Feedback Guide which gives a high-level overview of the concepts covered in the project. Take a moment to go through the Swift 3 style guides and tweak your project to conform to these style conventions.

ckypros commented 2 years ago

Are you sure this email was not submitted in error? My app went well above the requirements listed, including lots of extra interactions and UI modifications.

On Sat, Feb 5, 2022 at 2:06 AM CodePath Reviewers @.***> wrote:

Thanks for submitting your pre-work, but your current submission is incomplete. Your app does not complete all the required stories outlined as part of the prework. The following required user stories were not shown in your gif:

  • User can enter a bill amount, choose a tip percentage, and see the tip and total values.
  • User can select between tip percentages by tapping different values on the segmented control and the tip value is updated accordingly

Please review the prework submission checklist https://courses.codepath.org/snippets/ios_university/prework.md#heading-submission-checklist to complete the missing features. Please re-submit your project on your application dashboard https://apply.codepath.org/dashboard/, and it will notify us to review again.

— Reply to this email directly, view it on GitHub https://github.com/ckypros/IOS-Tip-Calculator/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AINZT5E36QL5MASGVC6JSHDUZTZEBANCNFSM5NTX35LA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

ckypros commented 2 years ago

So I replied to your email which generated the above response, but the email I replied to contained a significantly different message than what was included here…

C7DB8442-3375-4031-83F4-55597C2E7F7C

Perhaps my work got confused with another submission, generating a bad response?

codepathreview commented 2 years ago

Hello there,

Thanks for getting back to us. We apologize for the confusion. Our team have already reviewed your assignment and it seems that it was initially marked Incomplete. If this happens, an automatic email will be sent to you. However, it looks like that the incomplete status was updated right away to complete and the feedback posted here in your Github repository was edited. Again, we apologize for the error. We assure you that the assignment is now marked correct and complete. We are hoping for your kind understand. We will do our best to not make the same mistake.

ckypros commented 2 years ago

No problem at all I was just panicked because I am very interested in participating in the class! Thanks for the follow up!

On Sun, Feb 6, 2022 at 8:40 PM CodePath Reviewers @.***> wrote:

Hello there,

Thanks for getting back to us. We apologize for the confusion. Our team have already reviewed your assignment and it seems that it was initially marked Incomplete. If this happens, an automatic email will be sent to you. However, it looks like that the incomplete status was updated right away to complete and the feedback posted here in your Github repository was edited. Again, we apologize for the error. We assure you that the assignment is now marked correct and complete. We are hoping for your kind understand. We will do our best to not make the same mistake.

— Reply to this email directly, view it on GitHub https://github.com/ckypros/IOS-Tip-Calculator/issues/1#issuecomment-1031068241, or unsubscribe https://github.com/notifications/unsubscribe-auth/AINZT5AYC3VG47ADJMTP4JLUZ5EMXANCNFSM5NTX35LA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>