cl0wng1rl / qual-id

A RESTful API that returns randomly generated, custom qualitative ID's. All contributions welcome. Beginner friendly!
https://qual-id.herokuapp.com/
MIT License
9 stars 27 forks source link

Add company category #39

Closed aldinaufal21 closed 4 years ago

aldinaufal21 commented 4 years ago

sorry @gabrielbarker , i still don't understand what is explained in contribution.md. for code from import print (sorted ( () .get_values ())) where is it written? I have followed for __category_map it must be alphabetical, but it still has an error ..

rubysdeadname commented 4 years ago

@aldinaufal21 The values in get_values in company.py need to be alphabetical The code in contributing tells you how to quickly alphabetise a list. i.e.

Also, if you click on Details next to the build failed box on this page, and then click the build you will be able to see the jobs ran for this PR. If you click one of the jobs and go to the job log, at the bottom you can see the test failures. These should tell you why they have failed and in what file the error occured 🙂

codecov-commenter commented 4 years ago

Codecov Report

Merging #39 into main will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #39   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           64        66    +2     
  Lines          599       613   +14     
=========================================
+ Hits           599       613   +14     
Impacted Files Coverage Δ
qual_id/categories/company.py 100.00% <100.00%> (ø)
qual_id/pattern.py 100.00% <100.00%> (ø)
test/categories/test_company.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fd1cd38...7e84686. Read the comment docs.

rubysdeadname commented 4 years ago

Thanks a lot @aldinaufal21 !🙂