cl0wng1rl / qual-id

A RESTful API that returns randomly generated, custom qualitative ID's. All contributions welcome. Beginner friendly!
https://qual-id.herokuapp.com/
MIT License
9 stars 27 forks source link

Issue #42, Added new category Currency #60

Closed devanaggarwal closed 4 years ago

rubysdeadname commented 4 years ago

Hey @devanaggarwal , I really like this idea for a category but I was expecting it to be like

devanaggarwal commented 4 years ago

Sounds better, I will make the changes.

codecov-io commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@d390b5c). Click here to learn what that means. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##             main       #60   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?        78           
  Lines           ?       697           
  Branches        ?         0           
========================================
  Hits            ?       697           
  Misses          ?         0           
  Partials        ?         0           
Impacted Files Coverage Δ
qual_id/categories/currency.py 100.00% <100.00%> (ø)
qual_id/pattern.py 100.00% <100.00%> (ø)
test/categories/test_currency.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d390b5c...aa2e5e2. Read the comment docs.

devanaggarwal commented 4 years ago

hey @gabrielbarker, please review the changes.

rubysdeadname commented 4 years ago

Thanks for the contribution and thanks so much for making those changes @devanaggarwal ! 🎉 🙂