search

cl0wng1rl / qual-id

A RESTful API that returns randomly generated, custom qualitative ID's. All contributions welcome. Beginner friendly!
https://qual-id.herokuapp.com/
MIT License
9 stars 27 forks source link

Changes made as requested for Element category #61

Closed GoldDust69 closed 4 years ago

GoldDust69 commented 4 years ago

Apologies, I somehow closed the previous PR rather than adding a new commit but here are the changes made, including your suggested amendments :)

codecov-io commented 4 years ago

Codecov Report

Merging #61 into main will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #61   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           76        78    +2     
  Lines          683       697   +14     
=========================================
+ Hits           683       697   +14
Impacted Files Coverage Δ
qual_id/categories/element.py 100.00% <100.00%> (ø)
qual_id/pattern.py 100.00% <100.00%> (ø)
test/categories/test_element.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ccbf9a7...d873958. Read the comment docs.

rubysdeadname commented 4 years ago

Thanks a lot @GoldDust69 ! And thanks for changing all the file names too! That's going above and beyond 🎉 🙂