cl0wng1rl / qual-id

A RESTful API that returns randomly generated, custom qualitative ID's. All contributions welcome. Beginner friendly!
https://qual-id.herokuapp.com/
MIT License
9 stars 27 forks source link

Add new category for bird #66

Closed jaqsparow closed 4 years ago

jaqsparow commented 4 years ago

Adding new category for bird :)

codecov-io commented 4 years ago

Codecov Report

Merging #66 into main will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #66   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           86        88    +2     
  Lines          753       767   +14     
=========================================
+ Hits           753       767   +14     
Impacted Files Coverage Δ
qual_id/categories/bird.py 100.00% <100.00%> (ø)
qual_id/pattern.py 100.00% <100.00%> (ø)
test/categories/test_bird.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 295252d...81fa08a. Read the comment docs.

rubysdeadname commented 4 years ago

Thanks again @jaqsparow , fantastic contribution 🙂

jaqsparow commented 4 years ago

👍🏻

jaqsparow commented 4 years ago

Just checking. Did you push the changes to heroku? I still see 'bird' as invalid category

rubysdeadname commented 4 years ago

Thanks for bringing this to my attention, apparently the deploy failed. All good now though! As you can see

jaqsparow commented 4 years ago

Looks good now :)