Codecov Report

Merging #69 into main will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #69   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           92        94    +2     
  Lines          795       809   +14     
=========================================
+ Hits           795       809   +14

Impacted Files	Coverage Δ
qual_id/categories/anime.py	`100.00% <100.00%> (ø)`
qual_id/pattern.py	`100.00% <100.00%> (ø)`
test/categories/test_anime.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1755725...ec9b838. Read the comment docs.

rubysdeadname commented 4 years ago

Hey @gremlin97 , thanks for sorting out those failing tests. I've mentioned this to other people who've contributed, but in CONTRIBUTING.md, where I've requested that spaces and special characters not be included, what I mean is that I would like values to be single words. Some of your contributions here are clearly fine, like 'naruto', but others that are just multiple words combined are not. Would you be able to still add this category, but only use single words? Let me know your thoughts 🙂

gremlin97 commented 4 years ago

Yeah Sure :smiley: . Now that I think about it, having complex concatenated strings definitely beats the purpose of qual-id :sweat_smile: .

rubysdeadname commented 4 years ago

Great contribution @gremlin97 ! Thanks a lot! 🎉 🙂

gremlin97 commented 4 years ago

Thanks for the help :tada:. Looking forward to contribute in the future :smile:.

cl0wng1rl / qual-id

Added anime category class #69

Codecov Report