search

cl7 / CLTypingLabel

iOS UILabel with character by character typing /typewriter animation
https://cocoapods.org/pods/CLTypingLabel
MIT License
330 stars 54 forks source link

"Restart" still has old text in dispatch queue #6

Closed dpelletier2017 closed 8 years ago

dpelletier2017 commented 8 years ago

When you click restart a couple of times rapidly, the letters get all mixed up with the previous strings. The Async Dispatch Queue should be erased when restarting.

dpelletier2017 commented 8 years ago

Update : Fixed in my latest Pull Request

cl7 commented 8 years ago

Merged. Thx a lot!

cl7 commented 8 years ago

Release this to v0.1.4 on cocoapod

cl7 commented 8 years ago

@f8th Just one small suggestion, you can link the email "david.pelletie88 a_t facebook.com" which you used to commit to your Github so that it would show your as a contributor. Now it is showing as "David Pelletier" rather than @f8th https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/

dpelletier2017 commented 8 years ago

Thanks, I have no idea why Xcode used my FB address in the commit headers, especially because they don't exist anymore. I managed to fix it for the upcoming commits using Terminal : https://help.github.com/articles/setting-your-email-in-git/

As for the commits I have done in the past, I'll try to validate my FB email if it's still possible !