search

clEsperanto / clij3

BSD 3-Clause "New" or "Revised" License
2 stars 0 forks source link

improve clij3 architecture #8

Open StRigaud opened 1 month ago

StRigaud commented 1 month ago

For now all the code is in the CLIJ3.java file.

Could it be possible to split the core code and the auto-generated code into 2 files? To facilitate maintenance and development

CC @haesleinhuepf

haesleinhuepf commented 1 month ago

I would also say, we should move the CLIJ3 class into a clij3 package. Does anything speak agains this?

StRigaud commented 1 month ago

i don't know, maybe @tinevez or @carlosuc3m can give us a hint on this

tinevez commented 1 month ago

I would stick to the 'split the class if it is >1000 lines'. We want to promote maintainability, so splitting core vs autogenerated makes sense as well. Does it make sense not to?

haesleinhuepf commented 1 month ago

Yes splitting makes sense! The auto-generated part was also in a separate file in CLIJ2.

carlosuc3m commented 1 month ago

yess, better to split it!!