clEsperanto / pyclesperanto

GPU-accelerated Image Processing library using OpenCL
https://clesperanto.github.io/
BSD 3-Clause "New" or "Revised" License
31 stars 6 forks source link

WIP: benchmarking affine transforms #197

Closed haesleinhuepf closed 2 months ago

haesleinhuepf commented 3 months ago

This demonstrates the issues reported in #196

StRigaud commented 3 months ago

@haesleinhuepf I have added a deprecated function with warning as well as a converter for numpy to list.

Doing it reveled a few issues:

StRigaud commented 3 months ago

closes #196

codecov-commenter commented 2 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 56.25000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 84.91%. Comparing base (e268b8e) to head (c030924).

Files Patch % Lines
pyclesperanto/_interroperability.py 56.25% 7 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #197 +/- ## ========================================== - Coverage 85.17% 84.91% -0.26% ========================================== Files 18 18 Lines 1814 1830 +16 ========================================== + Hits 1545 1554 +9 - Misses 269 276 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

StRigaud commented 2 months ago

Interpolation returns 0 image. This is fixed by clEsperanto/CLIc#310 which will be available in the next release of CLIc and pyclesperanto

StRigaud commented 2 months ago

This should work now with the 0.11.0 release (clEsperanto/CLIc#317 && clEsperanto/CLIc#310)

StRigaud commented 2 months ago

Notebook runs, with interpolation and deprecated warning.

Ready to be merged