search

clMathLibraries / clBLAS

a software library containing BLAS functions written in OpenCL
Apache License 2.0
844 stars 237 forks source link

clBLAS does not build with cmake < 2.8 #10

Closed pavanky closed 11 years ago

pavanky commented 11 years ago

When using cmake < 2.8, this is the error we see.

CMake Error at library/CMakeLists.txt:282 (include):
  include could not find load file:

    ExternalProject

CMake Error at library/CMakeLists.txt:283 (ExternalProject_Add):
  Unknown CMake command "ExternalProject_Add".

The build should either be checking for cmake version or we should alternative means to build this particular section.

pavanky commented 11 years ago

@kknox Let me know what is the preferable solution. We came across this when trying to build on a Scientific Linux 6.x system (same as redhat and centos 6.x). We got around this by installing 2.8 (from here http://pkgs.repoforge.org/cmake/).

Let me know which is the preferred method (i.e. forcing cmake version vs changing the cmake files)

kknox commented 11 years ago

@pavanky I plan to keep using the ExternalProject module in the future, as I hope to be able to integrate a 'superbuild' infrastructure into clMath, similar to what I did in Bolt. cmake 2.8.0 was released in 2009, so I do not think it unreasonable to require the higher minimum version. As a datapoint, the FFT library already requires 2.8.3 for windows.

I think the correct option here is to change cmake_minimum_required(VERSION 2.6) to cmake_minimum_required(VERSION 2.8) in the root level cmakefile.

pavanky commented 11 years ago

Pull request sent https://github.com/clMathLibraries/clBLAS/pull/11