Kernels in UserGemmClKernels.h not being wiped by clblasTeardown

[hughperkins]

Kernels in UserGemmClKernels.h probably not being wiped by clblasTeardown

See https://github.com/hughperkins/DeepCL/issues/31#issuecomment-151467324

(Note that I intend to submit a pull request for this, so mostly for information)

[hughperkins]

Created commit which hopefully fixes this, https://github.com/hughperkins/clBLAS/commit/2111bb0393688cccc35e4b49ea429ae052c89b71 . Will wait for confirmation from jakakonda that this does/doesn't fix the issue he is encountering, and then submit a pull request.

[hughperkins]

Fixed in https://github.com/hughperkins/clBLAS/commit/7d708e4b5e574117d74435f3bcd65840c2d8ba71

[hughperkins]

Note: test case to reproduce this:

/* ************************************************************************
 * Copyright 2013 Advanced Micro Devices, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 * ************************************************************************/

#include <sys/types.h>
#include <stdio.h>
#include <string.h>

/* Include CLBLAS header. It automatically includes needed OpenCL header,
 * so we can drop out explicit inclusion of cl.h header.
 */
#include <clBLAS.h>

void run() {
    #define M  4
    #define N  3
    #define K  16

    static const clblasOrder order = clblasColumnMajor;

    static const cl_float alpha = 1;

    static const clblasTranspose transA = clblasTrans;
    static const cl_float A[M*K];
    static const size_t lda = K;        /* i.e. lda = K */

    static const clblasTranspose transB = clblasNoTrans;
    static const cl_float B[K*N];
    static const size_t ldb = N;        /* i.e. ldb = N */

    static const cl_float beta = 0;

    static cl_float C[M*N];
    static const size_t ldc = N;        /* i.e. ldc = N */

    static cl_float result[M*N];

    static const size_t off  = 1;
    static const size_t offA = K + 1;   /* K + off */
    static const size_t offB = N + 1;   /* N + off */
    static const size_t offC = N + 1;   /* N + off */

    cl_int err;
    cl_platform_id platform = 0;
    cl_device_id device = 0;
    cl_context_properties props[3] = { CL_CONTEXT_PLATFORM, 0, 0 };
    cl_context ctx = 0;
    cl_command_queue queue = 0;
    cl_mem bufA, bufB, bufC;
    cl_event event = NULL;
    int ret = 0;

    /* Setup OpenCL environment. */
    err = clGetPlatformIDs(1, &platform, NULL);
    if (err != CL_SUCCESS) {
        printf( "clGetPlatformIDs() failed with %d\n", err );
        return;
    }
    printf("got platformids\n");

    err = clGetDeviceIDs(platform, CL_DEVICE_TYPE_GPU, 1, &device, NULL);
    if (err != CL_SUCCESS) {
        printf( "clGetDeviceIDs() failed with %d\n", err );
        return;
    }
    printf("got deviceids\n");

    props[1] = (cl_context_properties)platform;
    ctx = clCreateContext(props, 1, &device, NULL, NULL, &err);
    if (err != CL_SUCCESS) {
        printf( "clCreateContext() failed with %d\n", err );
        return;
    }
    printf("created context\n");

    queue = clCreateCommandQueue(ctx, device, 0, &err);
    if (err != CL_SUCCESS) {
        printf( "clCreateCommandQueue() failed with %d\n", err );
        clReleaseContext(ctx);
        return;
    }
    printf("created commandqueue\n");

    /* Setup clblas. */
    err = clblasSetup();
    if (err != CL_SUCCESS) {
        printf("clblasSetup() failed with %d\n", err);
        clReleaseCommandQueue(queue);
        clReleaseContext(ctx);
        return;
    }
    printf("setup blas ok\n");

    /* Prepare OpenCL memory objects and place matrices inside them. */
    bufA = clCreateBuffer(ctx, CL_MEM_READ_ONLY, M * K * sizeof(*A),
                          NULL, &err);
    bufB = clCreateBuffer(ctx, CL_MEM_READ_ONLY, K * N * sizeof(*B),
                          NULL, &err);
    bufC = clCreateBuffer(ctx, CL_MEM_READ_WRITE, M * N * sizeof(*C),
                          NULL, &err);

    err = clEnqueueWriteBuffer(queue, bufA, CL_TRUE, 0,
        M * K * sizeof(*A), A, 0, NULL, NULL);
    err = clEnqueueWriteBuffer(queue, bufB, CL_TRUE, 0,
        K * N * sizeof(*B), B, 0, NULL, NULL);
    err = clEnqueueWriteBuffer(queue, bufC, CL_TRUE, 0,
        M * N * sizeof(*C), C, 0, NULL, NULL);

    /* Call clblas extended function. Perform gemm for the lower right sub-matrices */
    printf("calling sgemm....\n");
    err = clblasSgemm(order, transA, transB, M, N, K,
                         alpha, bufA, 0, M,
                         bufB, 0, K, beta,
                         bufC, 0, M,
                         1, &queue, 0, NULL, &event);
    if (err != CL_SUCCESS) {
        printf("clblasSgemmEx() failed with %d\n", err);
        ret = 1;
    }
    else {
        /* Wait for calculations to be finished. */
        err = clWaitForEvents(1, &event);
        clReleaseEvent(event);

        /* Fetch results of calculations from GPU memory. */
        err = clEnqueueReadBuffer(queue, bufC, CL_TRUE, 0,
                                  M * N * sizeof(*result),
                                  result, 0, NULL, NULL);
    }

    /* Release OpenCL memory objects. */
    clReleaseMemObject(bufC);
    clReleaseMemObject(bufB);
    clReleaseMemObject(bufA);

    /* Finalize work with clblas. */
    clblasTeardown();

    /* Release OpenCL working objects. */
    clReleaseCommandQueue(queue);
    clReleaseContext(ctx);
}

int
main(void)
{
    for(int i=0; i < 3; i++) {
        printf("i=%i\n", i);
        run();
        printf("finished ok :-)\n");
    }
    return 0;
}

compile and run like:

gcc -std=c99 -I.. -o test169 clblas_issue_169.c -L../build/library -lclBLAS -lOpenCL \
  && LD_LIBRARY_PATH=../build/library ./test169

Result:

$ ./run_169.sh 
i=0
got platformids
got deviceids
created context
created commandqueue
setup blas ok
calling sgemm....
finished ok :-)
i=1
got platformids
got deviceids
created context
created commandqueue
setup blas ok
calling sgemm....
finished ok :-)
i=2
got platformids
got deviceids
created context
created commandqueue
setup blas ok
calling sgemm....
finished ok :-)

[TimmyLiu]

Hi Hugh, Can we close this issue?

[hughperkins]

Thanks!