search

clMathLibraries / clBLAS

a software library containing BLAS functions written in OpenCL
Apache License 2.0
839 stars 240 forks source link

cmake needs to detect python and python version #196

Closed TimmyLiu closed 8 years ago

TimmyLiu commented 8 years ago

since python 2.7 is required now, cmake should detect python as well as python version at config time. We can probably use FindPythonLibs here: https://cmake.org/cmake/help/v3.0/module/FindPythonLibs.html

pavanky commented 8 years ago

:+1: I have been forcing cmake to use python2 manually.

pavanky commented 8 years ago

@TimmyLiu, I sent a patch in #199 that should work with both python2 and python3 interpreters. Will that resolve the issue?

TimmyLiu commented 8 years ago

@pavanky thanks for fixing for python3. But I still think cmake should at least check for python and complains if the system does not have python.

pavanky commented 8 years ago

@TimmyLiu you should be using FindPythonInterp instead. FindPythonLibs is required when you are compiling python modules I think.

pavanky commented 8 years ago

Alright sent a new PR for fixing this.