search

clMathLibraries / clBLAS

a software library containing BLAS functions written in OpenCL
Apache License 2.0
843 stars 237 forks source link

For discussion: fix memory leak with xgemm #250

Closed hughperkins closed 8 years ago

hughperkins commented 8 years ago

This addresses a memory leak in xgemm, which causes the cl context to not be released during teardown, consuming ~50-70MB per setup/release cycle, https://github.com/clMathLibraries/clBLAS/issues/247

I've labelled this as 'for discussion', since it's not thread safe. It is however suitable for my own use, but it should hvae some mutexes or similar to work for multi-threading scenarios.

This change is Reviewable

pavanky commented 8 years ago

I got the mutex stuff to work but was having issues with the tuner and ktest not compiling.. Looks like all I had to do was put it inside the ifdef block..

I will rebase my work based on yours and send in a new PR (you wont lose your commit)

hughperkins commented 8 years ago

Cool. Sounds good :-)

kknox commented 8 years ago

Any update on this?

pavanky commented 8 years ago

@kknox got carried away with other stuff on my plate. I will see if I can get something done this week.

kknox commented 8 years ago

Closing for inactivity