search

clMathLibraries / clBLAS

a software library containing BLAS functions written in OpenCL
Apache License 2.0
843 stars 237 forks source link

add missing dependency to pthread (using rwlock functions) #278

Closed zougloub closed 8 years ago

zougloub commented 8 years ago

Experiencing a build failure which is probably due to implicit dependency to -lpthread which might be satisfied by some OpenCL implementations. Explicitly specifying the dependency to pthread (used in common/rwlock.c solves the problem.

This change is Reviewable

tingxingdong commented 8 years ago

It does not pass the checks. Why do not you push it to dev branch?

zougloub commented 8 years ago

@tingxingdong I hadn't taken a look at https://github.com/clMathLibraries/clBLAS/tree/develop#contributing-code ... sorry. Having said that, I really can't make sense of the relation between the CI crashes and the proposed patch.

tingxingdong commented 8 years ago

@zougloub , pull request to develop branch. Then it will pass the check!

kknox commented 8 years ago

Is your distro Ubuntu by any chance? I have had issues in the past with pthread and Ubuntu, I think related to ld --as-needed flags use in ubuntu

kknox commented 8 years ago

Please target the /develop branch with PR's