search

clMathLibraries / clBLAS

a software library containing BLAS functions written in OpenCL
Apache License 2.0
839 stars 240 forks source link

Point the CONTRIBUTING wiki links to the correct repository #280

Closed IvanVergiliev closed 8 years ago

IvanVergiliev commented 8 years ago

The links to the wiki currently point to a repo that doesn't contain the linked documents.

This change is Reviewable

tingxingdong commented 8 years ago

In this pull request and pull request #278. the only changes are in documentation. No real code is touched. Yet, both do not pass the check because of the same error: the CL/cl.h is not found which is caused by the environment variable "OPENCL_INCLUDE_DIRS" not defined. @kknox , maybe we can approve the two pull requests?

TimmyLiu commented 8 years ago

Also want to point out the PR should be made to develop branch instead of master branch.

tingxingdong commented 8 years ago

Waaa, Timmy, welcome back!

tingxingdong commented 8 years ago

@IvanVergiliev , can you pull request to develop branch instead of the master? like in your the other PR.

IvanVergiliev commented 8 years ago

@tingxingdong @TimmyLiu thanks for the response. I did consider doing it in the develop branch. However, it seems that changes from develop haven't been merged into master for a while (~7 months, to be precise), and most people will probably read the documentation from master. Thus, merging it into master will fix it for people sooner than the other way.

If you insist, I can rebase onto develop - e.g. if it would break your git workflow, etc. But I do think that this way wouldn't hurt the stability of master and would have some advantages.

WDYT?

tingxingdong commented 8 years ago

Hi, @IvanVergiliev do it for both develop and master.

kknox commented 8 years ago

@IvanVergiliev If the fix is not checked into /develop, there is a possibility that the fix will be overridden on the next promotion from /develop into /master. The fix should be applied into /develop and 'trickle down'. It has been a while since there has been a promotion, and it's overdue. It will happen shortly.

kknox commented 8 years ago

Make the pull request into /develop, and we'll merge. Also, I believe the build should pass in /develop because the opencl 'finding' logic has been updated.

IvanVergiliev commented 8 years ago

@kknox sounds reasonable. The new PR is here: https://github.com/clMathLibraries/clBLAS/pull/282 .