clang with -std=c++11 fails to compile the project because there are narrowing conversions in src/library/blas/xtrsm.cc and a bunch of other files. The problem is reproducible for me if instead of
Disabling the error seems like the easiest solution. Another alternative is to add explicit casts, but it touched multiple places in the code so I figured that this is the safer path.
Also, having an explicit section with compile options for clang may save some confusion - I spent quite a bit of time wondering why my CXXFLAGS are not respected until I realized that clang is not considered a GNUCXX compiler so the first if does not apply to it.
clang with
-std=c++11fails to compile the project because there are narrowing conversions insrc/library/blas/xtrsm.ccand a bunch of other files. The problem is reproducible for me if instead ofI set
Disabling the error seems like the easiest solution. Another alternative is to add explicit casts, but it touched multiple places in the code so I figured that this is the safer path.
Also, having an explicit section with compile options for clang may save some confusion - I spent quite a bit of time wondering why my CXXFLAGS are not respected until I realized that clang is not considered a GNUCXX compiler so the first
ifdoes not apply to it.This change is