search

clMathLibraries / clSPARSE

a software library containing Sparse functions written in OpenCL
Apache License 2.0
173 stars 61 forks source link

64 bit containers replacing int/ cl_long with user defined type clsparseidx_t #178

Closed kvaragan closed 8 years ago

kknox commented 8 years ago

Hi Kiran~ After fixing the build, please review this PR for opportunities to squash commits. I have small alarms in my head that go off when I see 16 and counting commits. I don't want you to squash everything into 1 massive commit, and I don't think there is a 'right' number, but think about commits that may have dependencies. For instance, if I were to pick a random commit, would I be able to unroll that commit on it's own and still be able to compile, or would it depend on another commit to also be unrolled? Those would be commits that are candidates to be squashed together. f31e9b2 could definitely be squashed away. Even just squashing 2-3 commits is worth the time, in my opinion, to make the commit history cleaner.

Be careful when squashing, it can be destructive because it changes your history. It's never a bad idea to make a copy of your branch and squash in the copy. If it messes up you can delete the branch and start over.

kvaragan commented 8 years ago

Sure I will do that squashing. AppVeyor build showing build failed. Yesterday it was showing build successful

kvaragan commented 8 years ago

Closing it now, need to squash the commits.