clMathLibraries / clSPARSE

a software library containing Sparse functions written in OpenCL
Apache License 2.0
173 stars 60 forks source link

Ignore errors / warnings when using deprecated cl1.2 functions #189

Closed pavanky closed 8 years ago

pavanky commented 8 years ago

This change is Reviewable

pavanky commented 8 years ago

This patch reduces the number of warnings in the downloaded version of cl2.hpp, so it is not essential in those cases, but it is necessary to build clSparse with the version of cl2.hpp shipped by various distros which contain the older, buggy, version.

kknox commented 8 years ago

Hi @pavanky, I have existing code in our FindOpenCL.cmake that deals with issues like these warnings. Looks like I had nothing for 1.2. I would prefer that this fix make it into this file instead. I'm going to close this PR, and we'll get this patched on monday

kknox commented 7 years ago

@pavanky I pushed a simple commit with the macro in FindOpenCL in kknox/develop. Is there a way to test that this solves the problem?

pavanky commented 7 years ago

@kknox that works.

pavanky commented 7 years ago

I tested this on an archlinux machine with the packaged version of opencl-headers. You should be able to test the same on either Ubuntu 16.04 or Debian Testing.