clach04 / pebble_patch_tts

Patch Pebble smartwatch PBW binaries to remove punctuation from dictation/TTS and lower case
GNU General Public License v3.0
1 stars 0 forks source link

Mathmatical Characters Are Being Deleted #1

Open jj49er opened 2 years ago

jj49er commented 2 years ago

The script is deleting mathematical characters in addition to punctuation. This renders calculator apps still useless. Can certain mathematical characters be excluded in this script, or in an alternate script for certain apps requiring those characters, but not being able to process the punctuation?

clach04 commented 2 years ago

Bug or feature :smiley_cat: ? For my use case, I'm not interested in that (I personally want any words) BUT that's a great idea for those that need it, and for specific apps :+1:

Ideas:

To implement this, you'd need to use a custom C function (or hack isgraph, which I would recommend avoiding as it would be non-obvious to maintainers versus a custom written function). So yes totally doable, but you need to mask those specific characters or re-implement the filter function.

Long term, I think the best bet would be for when Cobble https://github.com/pebble-dev/mobile-app arrives to have per pebble app settings on the phone for controlling speech to text processing. I've been thinking about this for a while but not been on the Discord for a while to float the idea. I did wonder about updating the dictation server but it has no idea which app is running where as the phone app does (it only knows which user).

Long story short, I'll happily review a well written PR :-)