claczny / VizBin

Repository of our application for human-augmented binning
27 stars 14 forks source link

Remove binaries from repo #44

Closed piotr-gawron closed 5 years ago

piotr-gawron commented 5 years ago

Dear @claczny,

Here is a small PR that removes binaries from repository and changes java frontend into maven project.

Please accept it if you agree with the changes. I have few question though:

claczny commented 5 years ago

Hi @piotr-gawron

thanks a lot!

Regarding your Qs:

Do you know where this library was downloaded originally? Or maybe what was the fourth parameter about?

Sadly not, as this dates back quite some time. Indeed, this is a strange constructor that was used. We should simply use the current version then while we are anyways updating the code.

former build process generated javadocs. Do we need it? I removed it from the process, but if it's necessary I can work on it.

I can't remember that someone has requested or used it explicitly in the past. Hence, I would consider it reasonable to remove (for now).

can we separate build of the app into 4 possibilities:

Sure