cladera / videojs-offset

VideoJS plugin for play a segment of a video.
MIT License
64 stars 43 forks source link

Do not remove `timeupdate` handler on segment end #35

Closed m1ch3lp3r3z closed 5 years ago

m1ch3lp3r3z commented 5 years ago

This fixes second playback without end boundary

Description

If the media (segment) is watched until the end and then replayed, that second time it won't pause at the end time provided.

Specific Changes proposed

Removed line where the timeupdate handler is taken off from the player.

Requirements Checklist

DanielWare commented 5 years ago

I agree with this change. I've seen the same bug happen where the video plays to the offset end time for the first play through, then on each subsequent play through, the video plays to the end of the video.

cladera commented 5 years ago

@m1ch3lp3r3z can you rebase and push again?

cladera commented 5 years ago

Las patch fixes this issue.