First off, thank you for your work on this! It looks to be exactly what we need for a simple video editor project. 🙏
We have a particular situation where we show an overlay on the video once it ended. If the user starts scrubbing after this, we remove the overlay to give them access to the video again. We noticed that this line:
We couldn't figure out the need for this.currentTime(this._offsetEnd - this._offsetStart) (we removed it locally and didn't see any bad effects). Can you tell us what it's needed for?
Would you be willing to change the behavior? Either be removing this.currentTime(this._offsetEnd - this._offsetStart) or by making it configurable.
I'm happy to submit a PR either way, just want to know if it's a direction your willing to take before committing the time 😄
👋
First off, thank you for your work on this! It looks to be exactly what we need for a simple video editor project. 🙏
We have a particular situation where we show an overlay on the video once it ended. If the user starts scrubbing after this, we remove the overlay to give them access to the video again. We noticed that this line:
https://github.com/cladera/videojs-offset/blob/a02f42d88f58df50ef8974e53e4f7364e99086bc/src/plugin.js#L35
makes the player emit a
seekingevent after the end event onhttps://github.com/cladera/videojs-offset/blob/a02f42d88f58df50ef8974e53e4f7364e99086bc/src/plugin.js#L27
We couldn't figure out the need for
this.currentTime(this._offsetEnd - this._offsetStart)(we removed it locally and didn't see any bad effects). Can you tell us what it's needed for?Would you be willing to change the behavior? Either be removing
this.currentTime(this._offsetEnd - this._offsetStart)or by making it configurable.I'm happy to submit a PR either way, just want to know if it's a direction your willing to take before committing the time 😄