claffin / cloudproxy

Hide your scrapers IP behind the cloud. Provision proxy servers across different cloud providers to improve your scraping success.
https://cloudproxy.io/
MIT License
1.4k stars 80 forks source link

Allowed IP as alternative auth #52

Closed serk7 closed 2 years ago

serk7 commented 3 years ago

Actually i'm working with a project with same name called CloudProxy (https://github.com/NoahCardoza/CloudProxy). It's to pass throw cloudflare challenge. To do that is using a chrome with pupeeter. It's starting a chrome browser passing a proxy via parameter but it doesn't accept user and password on it (https://superuser.com/questions/902620/google-chrome-proxy-settings-with-username-and-password). This is the motivation to fork it and implement an alternative way to authenticate with proxy than using user and password. I used the parameter allowed_ip from tinyproxy.

Implemented:

Since is the first time i do something on python and docker. Probably is not really optimitzed and i guess there is space to enhance. I tested it on DigitalOcean, Hetzner and AWS and it works flawless without problems atm.

I published a docker image: bubexel/cloudprroxy:latest

Thank you for your work on it!

Greetings

claffin commented 2 years ago

Many thanks for your contribution and sorry for the late PR review. Taking a look at this over the next day or so to merge.

claffin commented 2 years ago

@serk7 reviewed and tested these look good. I've added some questions about some of the changes you've made above. Let me know your thoughts otherwise I will make them myself as appreciate it's been a while since you submitted this PR.

claffin commented 2 years ago

Closed as stale, but will implement some features still and credit appropriately.

serk7 commented 2 years ago

Hello Claffin, About why i added /24. I really don't remember why i did this change to be honest.

serk7 commented 2 years ago

Btw, i saw today the email about you closing it. For some reason i didn't read the other emails when you commented. I'm really sorry for don't response in time. Now i'm working but this evening i will check my commits and i will reply your questions.