By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the Apache License 2.0; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
thanks a lot for this PR, here are some suggestions:
I think it would be nice to have a generic component able to work on any image data source not only xview - I think the code might be already doing this
can we rename this component to: image-tiling?
can you please also add a destination folder parameter (in addition to the source folder)
can we rename window_size to tile_size_x and tile_size_y (and also support non-quadratic tiles?
in the case of sliding windows we should add a parameter stride_x and stride_y to control how the windows are moving over the source image
this is a hard one and might need to be taken into a separate issue, but in geospatial images (also in medical images) there is meta data associated (e.g. in a geotiff) - if you extract tiles from such an image the tile should also have the metadata copied over and adjusted for the new image size (e.g. if you greate a tile from a large satellite image then the metadata should be adjusted to reflect the new coordinates)
What changes were proposed in this pull request?
How was this pull request tested?
Developer's Certificate of Origin 1.1