Closed acsor closed 6 years ago
How soon can you make this change you propose, Oscar?
Cameron Laird, vice president We make computers work for people.
On Tue, Sep 11, 2018 at 9:31 AM, Oscar notifications@github.com wrote:
I propose to change the filesystem of the project structure. Currently, it seems that PyPDF4 does non-stadard:
- The location of the source files (only one source folder with as many nested children as it needs be is better IMHO)
- The nomenclature of the directories: they should be all lowercase, especially those belonging to module and package directories as recommended by PEP 8 https://www.python.org/dev/peps/pep-0008/#package-and-module-names (see also #12 https://github.com/claird/PyPDF4/issues/12).
If we approve this in time, I can ship its corresponding revision right with PR #14 https://github.com/claird/PyPDF4/pull/14. First though I'll have to make sure that all the dependencies and setup.py work correctly.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/claird/PyPDF4/issues/15, or mute the thread https://github.com/notifications/unsubscribe-auth/AAbN9FzsZnoabAA39U3V0Afj58PKy2j0ks5uZ8k2gaJpZM4WjbrE .
Right away. I hope and plan to be done with it in a couple of days top.
I'll make sure it receives my prompt attention.
Cameron Laird, vice president We make computers work for people.
On Tue, Sep 11, 2018 at 4:45 PM, Oscar notifications@github.com wrote:
Right away. I hope and plan to be done with it in a couple of days top.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/claird/PyPDF4/issues/15#issuecomment-420436427, or mute the thread https://github.com/notifications/unsubscribe-auth/AAbN9N8LZGHZysNEYC454Rd6Sg4TJcd9ks5uaC8HgaJpZM4WjbrE .
It seems I'm done with the change. PyPDF4 is more neat than ever -- please check it out to ensure the 18 tests pass (they all did with me).
Closed with #14.
I propose to change the filesystem of the project structure. Currently, it seems that PyPDF4 does non-stadard:
If we approve this in time, I can ship its corresponding revision right with PR #14. First though I'll have to make sure that all the dependencies and
setup.py
work correctly.