search

claird / PyPDF4

A utility to read and write PDFs with Python
obsolete-https://pythonhosted.org/PyPDF2/
Other
328 stars 61 forks source link

Add getAttachFiles() on PdfFileReader #56

Open alexis-via opened 5 years ago

alexis-via commented 5 years ago

Add a method to get all attachments from a PDF file.

I'm not an expert of PDF and this is my very first contribution to PyPDF. I'm working on the Factur-X / ZUGFeRD invoicing standards (PDF invoice with an embedded XML file) and I'm the author of the factur-x python lib (https://github.com/akretion/factur-x) that depend on PyPDF4. I think it would be great to have a method to get all attachments directly in the PyPDF lib.

If you think this PR has some chances to be accepted, I'll add unit tests for the getAttachFiles method.

claird commented 4 years ago

Alexis, please accept my apology for the many months I've made you wait. Yes, please provide unit tests so we can commit this without further delay.