Template updates needed

sayedihashimi commented 6 years ago

I reviewed your template and have the following comments.

[x] template.json should define guids which need to be replaced. You should include every <ProjectGuid> from .*proj files. You can use this PowerShell statement to find all guids Get-ChildItem .\ * -Recurse -File|Select-String '[0-9a-f]{8}-[0-9a-f]{4}-[1-5][0-9a-f]{3}-[89ab][0-9a-f]{3}-[0-9a-f]{12}'.
[ ] Add  at the top of all MSBuild files (.*proj files), see (this comment)[https://github.com/dotnet/templating/issues/1195#issuecomment-321344890] for more info
[x] After creation there is a LICENSE file with your name on it. The file should either not be dropped or your name should be removed at least.

Some other things I noticed

One other thing to consider. I noticed that you included the launchSettings.json file. I'm guessing this is because you wire up the projects to talk to each other via their specific ports. One drawback from this approach is that the same port numbers will be used. This should work fine in most cases so it's not a big deal. If a user has two different instances of VS with a different solution in each only one of them will run at a time. I think we have all the features you would need to generate a new port number and then include that as a replacement into the launchSettings.json, see https://github.com/dotnet/templating/wiki/Reference-for-available-macros.

clairernovotny commented 6 years ago

Thanks, I'll make the appropriate updates!

clairernovotny commented 6 years ago

I've taken care of the guid's and license file. Does the MSBuild file issue apply as this template is only good with .NET Core 2? From the referenced issue, it seemed like a bug with the 1.0.4 SDK; is the 2.0 SDK affected? From the referenced issue, it's not clear that the comment goes at the top of the project file or on specific property groups, so I'm not sure where that'd have to be applied?

sayedihashimi commented 6 years ago

Does the MSBuild file issue apply as this template is only good with .NET Core 2

It's not about target framework version, but instead TemplateEngine version that VS2017 carries. It's a bug in older versions of TemplateEngine. If this template is used with vs2017 15.3 it will not work.correctly.

sayedihashimi commented 6 years ago

FYI if you add  it will not be included in the generated output, so there is no change from a user perspective to adding that.

clairernovotny commented 6 years ago

Okay, np. Does it go just once at the top of the project file or on each property group?

clairernovotny / AspNetCoreCloudService

Template updates needed #2