search

clairernovotny / ReferenceGenerator

MIT License
75 stars 13 forks source link

Fix for SemanticVersionPreReleaseTag Number parsing #13

Closed wgtmpeters closed 8 years ago

wgtmpeters commented 8 years ago

Fix for SemanticVersionPreReleaseTag Number parsing so that it can work with "number" group that is larger than MaxInt.

clairernovotny commented 8 years ago

Looping in @JakeGinnivan as I'm using the SemVer code from https://github.com/GitTools/GitVersion

Jake, what do you think?

JakeGinnivan commented 8 years ago

Looks fine to me, if it is that big then it is not going to be an incrementing number so thats fine to lose it.

On a side note I was thinking about pulling the SemVer classes from GitVersion out into a source only nuget package. Thoughts on that?

clairernovotny commented 8 years ago

A separate SemVer package would work for me (I'm ILMerge'ing everything in the project anyway) and it'd keep things more tidy.

clairernovotny commented 8 years ago

Thanks!