search

clalancette / oz

Automated installation for guest images
GNU Lesser General Public License v2.1
310 stars 129 forks source link

make vnc accessible from remote #241

Closed yan97ao closed 3 years ago

yan97ao commented 7 years ago

We create images from a remote server. This patch makes us can access vnc while kickstart stage and found out what's going wrong.

clalancette commented 7 years ago

While I can totally see why you would want this, it makes me really nervous to do this. This is opening up the installation process to anyone outside the current machine, with no encryption, passwords, etc. I'm not sure I would want to make this the default. I think this would be better as a command-line argument to oz-install, something like:

oz-install --vnc-listen-ip 0.0.0 /path/to/my/tdl

Does that make sense to you?

yan97ao commented 7 years ago

Yeah, this really bother me a lot too. It may invoke some security issues. But finally, I convinced myself that the installation process is quite quick. Toggle it by command-line argument is a good idea.I'll try to make it like: oz-install --vnc-listen-ip 0.0.0.0 --vnc-password $VNC_PASSWORD /path/to/my/tdl

clalancette commented 3 years ago

There hasn't been any movement on this PR in 3 years, so I'm going to assume that there isn't further interest. I'll close this for now, but feel free to reopen if you'd like to move forward with this.