search

clalancette / oz

Automated installation for guest images
GNU Lesser General Public License v2.1
310 stars 129 forks source link

Imagefactory 1.1.11 breaks with oz-0.17.x API issue #276

Open spstarr opened 4 years ago

spstarr commented 4 years ago 
2019-11-04 14:58:14,670 ERROR imgfac.Builder.Builder thread(6195c89c) Message: __init__() takes exactly 13 arguments (12 given)
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/imgfac/Builder.py", line 132, in _build_image_from_template
    self.os_plugin.create_base_image(self, template, parameters)
  File "/usr/lib/python2.7/site-packages/imagefactory_plugins/TinMan/TinMan.py", line 322, in create_base_image
    self._init_oz()
  File "/usr/lib/python2.7/site-packages/imagefactory_plugins/TinMan/TinMan.py", line 299, in _init_oz
    self.init_guest()
  File "/usr/lib/python2.7/site-packages/imagefactory_plugins/TinMan/TinMan.py", line 408, in init_guest
    self.guest = oz.GuestFactory.guest_factory(self.tdlobj, self.oz_config, install_script_name)
  File "/usr/lib/python2.7/site-packages/oz/GuestFactory.py", line 106, in guest_factory
    diskbus, macaddress)
  File "/usr/lib/python2.7/site-packages/oz/RHEL_7.py", line 79, in get_class
    return RHEL7Guest(tdl, config, auto, output_disk, netdev) #, diskbus)
  File "/usr/lib/python2.7/site-packages/oz/RHEL_7.py", line 38, in __init__

I was unable to run imagefactory to make an OVA.

Downgrading Oz to 0.16.x worked... unsure whats going on debugging the python code here.

spstarr commented 4 years ago

I would have assumed 0.16 -> 0.17 is a minor change vs API change :(

clalancette commented 4 years ago

I would have assumed 0.16 -> 0.17 is a minor change vs API change :(

Yep, and it is. We generally take API backwards compatibility seriously, not sure what is going on there.

spstarr commented 4 years ago

Neither, I've downgraded for now, at least i can build OVA images now, tried debugging the code, but I don't understand why that class import is failing.