clalancette / oz

Automated installation for guest images
GNU Lesser General Public License v2.1
310 stars 129 forks source link

Self-check failures due to 'useuefi' parameter? #295

Open jas4711 opened 2 years ago

jas4711 commented 2 years ago

Hi. I get self-test errors like the following in https://salsa.debian.org/jas/oz/-/jobs/2444739

tests/factory/test_factory.py::test_fedora_core FAILED                   [  3%]
...
    def test_fedora_core():
        for version in ["1", "2", "3", "4", "5", "6"]:
            for arch in ["i386", "x86_64"]:
                for installtype in ["url", "iso"]:
>                   runtest(distro='FedoraCore', version=version, arch=arch,
                            installtype=installtype, expect_success=True)
tests/factory/test_factory.py:121: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
tests/factory/test_factory.py:98: in runtest
    oz.GuestFactory.guest_factory(tdl, config, None)
/usr/lib/python3/dist-packages/oz/GuestFactory.py:105: in guest_factory
    klass = getattr(module, importname).get_class(tdl, config, auto,
/usr/lib/python3/dist-packages/oz/FedoraCore.py:96: in get_class
    return FedoraCoreGuest(tdl, config, auto, output_disk, netdev, diskbus,
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <oz.FedoraCore.FedoraCoreGuest object at 0x7f9d4ede4e50>
tdl = <oz.TDL.TDL object at 0x7f9d4ede4880>
config = <configparser.SafeConfigParser object at 0x7f9d4ede4910>, auto = None
output_disk = None, netdev = None, diskbus = None, macaddress = None
    def __init__(self, tdl, config, auto, output_disk, netdev, diskbus,
                 macaddress):
        self.config = version_to_config[tdl.update]
>       oz.RedHat.RedHatLinuxCDGuest.__init__(self, tdl, config, auto,
                                              output_disk, netdev, diskbus,
                                              True, True, self.config.initrdtype,
                                              macaddress)
E       TypeError: __init__() missing 1 required positional argument: 'useuefi'
/usr/lib/python3/dist-packages/oz/FedoraCore.py:62: TypeError

As far as I can tell, it seems related to b7728d5bde9741786d2cd60806411e8462cfb3e5

alexiri commented 2 years ago

I'm seeing this as well:

__init__() missing 1 required positional argument: 'useuefi'
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/imgfac/Builder.py", line 135, in _build_image_from_template
    self.os_plugin.create_base_image(self, template, parameters)
  File "/usr/lib/python3.6/site-packages/imagefactory_plugins/TinMan/TinMan.py", line 320, in create_base_image
    self._init_oz()
  File "/usr/lib/python3.6/site-packages/imagefactory_plugins/TinMan/TinMan.py", line 297, in _init_oz
    self.init_guest()
  File "/usr/lib/python3.6/site-packages/imagefactory_plugins/TinMan/TinMan.py", line 403, in init_guest
    self.guest = oz.GuestFactory.guest_factory(self.tdlobj, self.oz_config, install_script_name)
  File "/usr/lib/python3.6/site-packages/oz/GuestFactory.py", line 107, in guest_factory
    diskbus, macaddress)
  File "/usr/lib/python3.6/site-packages/oz/RHEL_9.py", line 65, in get_class
    macaddress)
  File "/usr/lib/python3.6/site-packages/oz/RHEL_9.py", line 38, in __init__
    macaddress)
  File "/usr/lib/python3.6/site-packages/oz/RHEL_8.py", line 39, in __init__
    False)
TypeError: __init__() missing 1 required positional argument: 'useuefi'