clalancette / oz

Automated installation for guest images
GNU Lesser General Public License v2.1
310 stars 129 forks source link

Don't write kickstart so initial-setup won't think root pw is set #307

Closed AdamWill closed 1 year ago

AdamWill commented 1 year ago

We previously landed this as https://github.com/clalancette/oz/commit/ef55a6402143f810b7c221c2763b7eb52b4b8261 but then had to revert it because the changes to initial-setup weren't done. Per this comment on the original bug report, the changes in initial-setup are done now, so it should be OK to put this back.

I do have one concern about whether we need the change to initial-setup in F37 as well, but that doesn't need to hold up merging this upstream, I don't think.

nullr0ute commented 1 year ago

I think that makes sense. Let's hope we don't need to revert a second time :)