Closed huettenhain closed 2 years ago
I have added all test cases that I found and wrote tests for them. All test cases are extracted by 7zip without any complaint, so I assume there must be some way to navigate them. I was able to relax a few exceptions to logger warnings, but some of the test cases are beyond my understanding of the library (and the ISO format) to fix.
Absolutely, I understand. I just had a free Sunday and wanted to get into the weeds a bit, maybe it's best to reject this PR. I am not sure I'll be able to construct the artificial test cases you desire 😅.
Absolutely, I understand. I just had a free Sunday and wanted to get into the weeds a bit, maybe it's best to reject this PR. I am not sure I'll be able to construct the artificial test cases you desire sweat_smile.
That's OK. If you make some simpler PRs that just have individual changes that allow you to get further, we can evaluate them one-by-one and I can probably come up with some reasonable tests for them.
This is my first attempt to contribute to #82; let me know if this works for you. Happy to change literally anything 🙂.