search

clamchowder / Microbenchmarks

Trying to figure various CPU things out
Apache License 2.0
77 stars 13 forks source link

Hardcode setting for numaNodeCount under NUMA mode #13

Closed troore closed 3 months ago

troore commented 4 months ago

Hi @clamchowder,

I found in MemoryBandwidth.c, under NUMA mode, there is a hardcode number (https://github.com/clamchowder/Microbenchmarks/blob/master/MemoryBandwidth/MemoryBandwidth.c#L620):

image

As the comment indicates, it may be for KNL. So should we recover the numaNodeCount back to numa_max_node() + 1 for other CPUs?

Thanks, troore

clamchowder commented 3 months ago

I modified the test to investigate specific NUMA platforms. NUMA in general is not supported by the tests here. If you wish to investigate a NUMA setup, you're on your own and might be better off writing your own microbenchmarks from scratch