clamp-orchestrator / clamp-core

A microservices flow orchestrator and workflow manager.
https://clamp-orchestrator.github.io/clamp-orchestrator/
MIT License
9 stars 4 forks source link

Refactoring workflow creation code to remove nested step update #39

Closed priyaaank closed 4 years ago

priyaaank commented 4 years ago

I have attempted to improve the following things in this commit. Please take a look and share your opinion.

I think from the code it is evident that sub-steps were added later on as we handle the id assignment for them separately instead of something like recursion. But I'll think and improve this a bit more.

I have not reviewed the tests and will do that next to improve the coverage and style. Please take a look and let's have a discussion. Having the discussion will promote consistency in code as we all will agree on things.

tejash-jl commented 4 years ago

@priyaaank need to resolve the conflicts