search

clamp-orchestrator / clamp-core

A microservices flow orchestrator and workflow manager.
https://clamp-orchestrator.github.io/clamp-orchestrator/
MIT License
9 stars 4 forks source link

Refactor long classes and methods #6

Open tejashjl opened 4 years ago

tejashjl commented 4 years ago

  1. Classes

    • service_request_worker.go
    • step_status_service.go

  2. Methods:

    • The cyclomatic complexity of these methods is also high
    • service_request_worker.ExecuteWorkflowStep
    • step_status_service.PrepareStepStatusResponse
    • async_resume_worker.resumeSteps

  3. Could the Repository class be split?

  4. The model classes don't seem to have much logic. This could be one of the reasons for long service classes/methods. Identify and move the business logic to the model classes