clams-tech / Remote

Remote control your Core Lightning node
https://remote.clams.tech
GNU General Public License v3.0
41 stars 7 forks source link

Enhancement: i18n Errors #135

Closed lnbc1QWFyb24 closed 8 months ago

lnbc1QWFyb24 commented 1 year ago

We need to ensure that we have internationalised all of the errors received from CoreLN based on the error code. A list of all CoreLN error codes can be found here.

We have some of these errors handled here, but are missing some.

We also need to ensure that all calls to the CoreLN rpc are using the error codes with a default of falling back to the message.

If we get a generic -1 code for an error that we know what it is for, we can create a patch PR for CoreLN to get it updated.

lnbc1QWFyb24 commented 8 months ago

Done in V2