clams-tech / Remote

Remote control your Core Lightning node
https://remote.clams.tech
GNU General Public License v3.0
41 stars 7 forks source link

Bug: Inconsistent QR scanning ability after saving to file. #183

Closed farscapian closed 7 months ago

farscapian commented 1 year ago

In all cases (BOLT12, BOLT11, Node Connect, and Node Pubkey) where QR codes are shown, my phone QR scanner works fine when the QR code is in the browser. However, when saving that QR to a file using the little save button on the lower right of the QR, then opening the resulting .png file, the QR code DOES NOT scan at all. Wondering if there's some bug here.

lnbc1QWFyb24 commented 1 year ago

I was able to scan saved and copied QR's but the export does not have any whitespace on the edges which may be making it harder to scan. #184 adds some padding around the QR which should help with making it easier to scan.

lnbc1QWFyb24 commented 1 year ago

@farscapian this has been merged in to production, so let me know if it fixes it on your end.