clamsproject / aapb-evaluations

Collection of evaluation codebases
Apache License 2.0
0 stars 1 forks source link

update timeframe `evaluate.py` #44

Closed keighrim closed 8 months ago

keighrim commented 8 months ago

Because

Related to #43 , we want to update now outdated evaluate.py under TF_eval directory. However, since the time when the script is written, there has been some changes regarding gold data organization. So we need to updated the script to cope with those changes.

Done when

This should include

  1. updating to use goldretreiver.py instead of manual download of gold files
  2. merging following two functions https://github.com/clamsproject/aapb-evaluations/blob/55b53e8c2e12a066c4ab1604b38aa4d7cacec355/timeframe-eval/evaluate.py#L56 https://github.com/clamsproject/aapb-evaluations/blob/55b53e8c2e12a066c4ab1604b38aa4d7cacec355/timeframe-eval/evaluate.py#L76

  3. Update start and end properties access with newly added helper methods via https://github.com/clamsproject/mmif-python/pull/254

Additional context

No response