search

clamsproject / app-swt-detection

CLAMS app for detecting scenes with text from video input
Apache License 2.0
1 stars 0 forks source link

releasing 5.0 #101

Closed marcverhagen closed 6 months ago

marcverhagen commented 6 months ago

Overview

This release adds a script to run a server-less app from the command line, adds and fixes parameters, and updates dependencies.

Additions

Changes

marcverhagen commented 6 months ago

Weird, you get that while running the container?

marcverhagen commented 6 months ago

@keighrim The yaml import does indeed seem superfluous and I will remove it. As for __init__ cleanup, the SwtDetection.__init__ method has some logging code that you put in there, mostly for timing purposes, I will be happy to remove it as well as other logging and timing elsewhere in the app.

marcverhagen commented 6 months ago

@keighrim By the way, the error you got is consistent with having the wrong version of clams-python, it needs 1.2.2 and when I replaced that with 1.2.1 I get the same error.

keighrim commented 6 months ago

Yup, that was python environment problem on my side, my bad. I can confirm the app.py runs fine.

marcverhagen commented 6 months ago

Hmmmm, I did fine an error with the CLI script which must have crept in late in the game. Sigh.

marcverhagen commented 6 months ago

After banging my head against the CLI "error" reported above for a while I realized the error was in a mistake with the arguments given to the CLI. So I am going to say we are good to go.