search

clamsproject / clams-python

CLAMS SDK for python
http://sdk.clams.ai/
Apache License 2.0
4 stars 1 forks source link

adding handling of warnings, undefined parameters to warnings #106

Closed keighrim closed 1 year ago

keighrim commented 1 year ago

Fixing #101 by changing default behavior given an undefined runtime parameter.

codecov[bot] commented 1 year ago

Codecov Report

Merging #106 (0c27054) into develop (8f5b1d2) will increase coverage by 0.69%. The diff coverage is 96.29%.

@@             Coverage Diff             @@
##           develop     #106      +/-   ##
===========================================
+ Coverage    80.36%   81.05%   +0.69%     
===========================================
  Files            6        6              
  Lines          438      454      +16     
===========================================
+ Hits           352      368      +16     
  Misses          86       86
Flag Coverage Δ
unittests 81.05% <96.29%> (+0.69%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
clams/app/__init__.py 87.71% <93.33%> (+0.46%) :arrow_up:
clams/appmetadata/__init__.py 89.91% <100.00%> (ø)
clams/restify/__init__.py 78.94% <100.00%> (+2.02%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

keighrim commented 1 year ago

In addition to changes in handling "undefined" parameters, this PR includes updates to comply with the new MMIF spec (adding warnings field, see https://github.com/clamsproject/mmif/issues/188).