clamsproject / clams-python

CLAMS SDK for python
http://sdk.clams.ai/
Apache License 2.0
4 stars 1 forks source link

validating input MMIF based on jsonschema #129

Closed keighrim closed 1 year ago

keighrim commented 1 year ago

As an improvement upon https://github.com/clamsproject/mmif-python/issues/163, we discussed using jsonschema (that's shipped with the mmif-python package found at the runtime) to validate all input MMIFs, instead of relying on version numbers encoded at the top-level of the input MMIS json.

keighrim commented 1 year ago

This has been already the case for input MMIF validation from the beginning. The issue we have (if it's an issue at all) actually isn't json validation, but the "equal" operation between the same vocab types from different versions, which has been discussed in various places (mostly directly in https://github.com/clamsproject/mmif-python/issues/23, but also in https://github.com/clamsproject/mmif-python/issues/14 and https://github.com/clamsproject/mmif-python/issues/163), and our latest conclusion was

Closing this as a non-issue.

keighrim commented 1 year ago

It turned out that this WAS NOT the case for the individual apps since https://github.com/clamsproject/clams-python/issues/60. Reopening the issue, and will keep it open until https://github.com/clamsproject/mmif-python/issues/163 is re-closed.