search

clamsproject / wfe-pipeline-runner

3 stars 1 forks source link

Container name unclarity #8

Closed marcverhagen closed 3 years ago

marcverhagen commented 3 years ago

It turned out to be confusing that clams_ was used as a prefix. And this really points at an unhealthy choice in the code where there is a hard-wired prefix clams_ that is prepended somewhere in an initialization method. Review how containers are named.

marcverhagen commented 3 years ago

This was changed by not suggesting to use container_name in the docker compose file. Now the container names are the defaults used by docker-compose, for example, if the service is called tokenizer then the container is called pipeline-runner_tokenizer_1.

marcverhagen commented 3 years ago

Well, that was nonsense, we needed to specify the names to access the containers from inside of another container. So I put back in the container name, but now used pipeline_ as a prefix instead of clams_ hoping that that would be less confusing.

The container name won't be needed anymore if we do not make the pipeline.py script run as a container anymore, which may happen (see issue #6).