clancy-chao / Steam-Bundle-Sites-Extension

A simple extension for bundles sites selling Steam games
MIT License
70 stars 5 forks source link

Script not liking title with quotation marks (Humble) #11

Closed DragRedSim closed 5 years ago

DragRedSim commented 5 years ago

The recent (February 2019) Humble Monthly included a key for some DLC for an included game, titled "Rapture Rejects - Humble Exclusive "Safari Outfit" DLC". The script doesn't like the use of quotation marks in a title, as it reports the following JS error: Error: Syntax error, unrecognized expression: .heading-text[data-title="Rapture Rejects - Humble Exclusive "Safari Outfit" DLC"] After this, no further games are checked for ownership. I'm guessing the fix involves checking the title for the quotation mark character, and escaping it, before passing it to the function. (Line 3530 seems to be where the search calculation is built.)

clancy-chao commented 5 years ago

Thank you for reporting this issue. Fixed now.