clang-randstruct / llvm-project

Randomize the order of fields in a structure layout as a compile-time hardening feature
3 stars 1 forks source link

Submit to Upstream #13

Closed tim-pugh closed 5 years ago

tim-pugh commented 5 years ago

Send an RFC (request for comment) email to the CFE-DEV mailing list describing your work and soliciting feedback.

We can put the code changes up on the code review website following the process described here https://llvm.org/docs/Phabricator.html under “Requesting a review via the web interface”.

We can provide a link to the review in the RFC thread.

tim-pugh commented 5 years ago

After the RFC and fixing suggestions the upstream patch can be submitted.

We will need to do this ASAP.

tim-pugh commented 5 years ago

We'll likely miss the Upstream goal, but the RFC should be scheduled to take place Friday if all goes well. Running all the new squashed commit hashes appear to pass. Thanks @jcantrell for the script to automate this and @connorkuehl for the git fu

connorkuehl commented 5 years ago

https://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20190304/263999.html

tim-pugh commented 5 years ago

https://lists.llvm.org/pipermail/cfe-dev/2019-March/061607.html

New link

tim-pugh commented 5 years ago

Leaving task open for the time being so the code review link is easily accessible

tim-pugh commented 5 years ago

Links added to wiki.

Closing this issue on down!